Open
Conversation
Reviewer's GuideThis PR replaces manual DOM measurement and style bindings for the selection indicator and tooltip with floating-ui’s computePosition and autoUpdate, enabling automatic placement and scroll-following. It refactors the template to wrap the indicator and tooltip in a positioned container, swaps out computed style logic for a watchEffect-driven update, and overhauls the CSS to use data-placement rules. Sequence diagram for selection and tooltip positioning with floating-uisequenceDiagram
actor User
participant SelectionTranslator
participant floating-ui
User->>SelectionTranslator: Selects text
SelectionTranslator->>floating-ui: computePosition(range, container)
floating-ui-->>SelectionTranslator: Returns x, y, placement
SelectionTranslator->>SelectionTranslator: Updates container style and data-placement
Note over SelectionTranslator: Tooltip and indicator follow scroll automatically
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `components/SelectionTranslator.vue:679` </location>
<code_context>
+ top: 0;
+ left: 0;
+ z-index: 9998;
+ width: 350px;
+}
+
</code_context>
<issue_to_address>
Hardcoding the wrapper width to 350px may reduce flexibility.
A fixed width may not display well on all devices or with varying content lengths. Making the width responsive or configurable would improve adaptability.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
width: 350px;
}
=======
width: var(--translator-width, 100%);
max-width: 350px;
}
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+679
to
+680
| width: 350px; | ||
| } |
There was a problem hiding this comment.
suggestion: Hardcoding the wrapper width to 350px may reduce flexibility.
A fixed width may not display well on all devices or with varying content lengths. Making the width responsive or configurable would improve adaptability.
Suggested change
| width: 350px; | |
| } | |
| width: var(--translator-width, 100%); | |
| max-width: 350px; | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
通过引入 floating-ui 实现划词翻译自动定位，自动跟随滚动
fix #143 #145