You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The latest commit adds _devel and -$TARGETARCH as suffixes to the BIOCONDUCTOR_NAME env variable.
Why _devel?
In the past we have built and pushed devel and release binaries under the same name, leading to them sharing the same directory in a bucket (eg: see 3.21 bucket). When moving to a new cycle, this effectively meant that the release binaries replace the devel binaries in the directory (previously deleting the old devel binaries completely, but with newer build method having them co-exist in the bucket). This puts users of old devel containers who haven't updated yet in the position of either a) inadvertently pulling binaries from the new release, because of the version bump making new release binaries take precedence, which could especially be problematic if an OS change occurred during the release process rendering them incompatible or b) force them to go back to compiling from source until they upgrade their devel containers.
With Bioconductor/BiocManager#199 having been merged (originally only to allow a path forward for arm64 binaries), adding the _devel prefix in the name for devel containers will also allow us to separate the directories of devel and release binaries in the bucket that hosts these binaries, and thus avoid this problem altogether, keeping backwards compatibility for devel container binaries even post-release.
Why -$TARGETARCH?
This creates a path for arm64 pre-compiled binaries, but also makes it easier for arm64 containers to never inadvertently use the amd64 binaries, even if the container binaries env variable is accidentally set to true (eg if using an existing script that sets it). This argument is automatically defined by docker during the build process, from the --platform argument.
If this change seems desirable, I would merge it with the release bump before rebuilding the binaries. @LiNk-NY@vjcitn any thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.