Add support for opening egui links in browser#12
Closed
helgoboss wants to merge 1 commit intoBillyDM:mainfrom
Closed
Add support for opening egui links in browser#12helgoboss wants to merge 1 commit intoBillyDM:mainfrom
helgoboss wants to merge 1 commit intoBillyDM:mainfrom
Conversation
helgoboss
force-pushed
the
feature/open-links-in-browser
branch
from
6741215 to
3bc457e
Compare
helgoboss
force-pushed
the
feature/open-links-in-browser
branch
from
3bc457e to
7255528
Compare
Contributor
Author
|
I will make a better PR as soon as RustAudio/baseview#144 is accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a minimal implementation that simply follows the example of egui-winit.
However, this shouldn't be merged yet because it requires a change in the baseview crate. Without that, a BorrowMut panic occurs because opening the webbrowser shortly reenters the window procecure.