Constraining clean target to source tree#14
Open
smoe wants to merge 1 commit intoBill-Gray:masterfrom
Open
Conversation
Files outside the source tree should not be touched. This would be an unexpected behaviour. Further, every line is executed in a new shell command, at least with UNIX, which is why the "cd" command has no effect on the lines below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
the clean just failed since the find_orb directory did not yet exist in my home directory. It is somewhat unexpected to see a clean target act outside the source tree. This would be an unexpected behaviour. Further, every line is executed in a new shell command, at least with UNIX, which is why the "cd" command has no effect on the lines below. So I expect the very unexpected with that code and have minimised to what is just removing files created at build time.