Drop support for EOL Ruby and Rails#89
Merged
samandmoore merged 2 commits intoSep 12, 2025
Merged
Conversation
samandmoore
reviewed
Sep 11, 2025
| @@ -1,3 +1,3 @@ | |||
| module WebValve | |||
| VERSION = "2.1.0" | |||
| VERSION = "3.0.0" | |||
Member
There was a problem hiding this comment.
in the past, in this project, we've dropped support in minor version bumps. i'd like to continue that here. can you swap the version change here to 2.2.0?
samandmoore
requested changes
Sep 11, 2025
samandmoore
left a comment
samandmoore
left a comment
Member
There was a problem hiding this comment.
just one thing about changing the version number
Irving-Betterment
force-pushed
the
drop_eol_rails_ruby_support
branch
from
3d8d9e8 to
bf35d2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
This pull request drops support for Rails and Ruby versions reached end of life (< Rails 7.2, < Ruby 3.2), in order to streamline the supportability bracket. By doing so, It also cuts a minor version release.