-
Notifications
You must be signed in to change notification settings - Fork 35
fix: ensure individually_overridden is reliably cleared #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmileham
wants to merge
1
commit into
Betterment:main
Choose a base branch
from
jmileham:fix_individually_overridden_leakage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
db/migrate/20260504164518_clear_stale_individually_overridden_flags.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| class ClearStaleIndividuallyOverriddenFlags < ActiveRecord::Migration[7.2] | ||
| def up | ||
| execute <<~SQL | ||
| UPDATE assignments | ||
| SET individually_overridden = false | ||
| WHERE individually_overridden = true | ||
| AND context IS DISTINCT FROM 'individually_overridden' | ||
| SQL | ||
| end | ||
|
|
||
| def down | ||
| raise ActiveRecord::IrreversibleMigration | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -233,15 +233,15 @@ | |
| end | ||
| end | ||
|
|
||
| it "remains during a bulk assignment" do | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seemed like "testing behavior that isn't part of the requirements" when I paged through the archived repository. I couldn't find any documented reason that this would be desirable behavior. It basically committed to what I think is a bug here. |
||
| it "is cleared during a bulk assignment" do | ||
| existing_assignment = FactoryBot.create(:assignment, existing_assignment_params.merge(individually_overridden: true)) | ||
| bulk_assignment = FactoryBot.create(:bulk_assignment, split: existing_assignment_params[:split]) | ||
|
|
||
| ArbitraryAssignmentCreation.create!(params.merge(bulk_assignment_id: bulk_assignment.id)) | ||
|
|
||
| expect(existing_assignment.reload.bulk_assignment).to eq bulk_assignment | ||
| expect(existing_assignment).to be_individually_overridden | ||
| expect(existing_assignment.context).to eq "individually_overridden" | ||
| expect(existing_assignment).not_to be_individually_overridden | ||
| expect(existing_assignment.context).to eq "bulk_assignment" | ||
| end | ||
|
|
||
| it "makes a previous bulk_assignment nil" do | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had an ephemeral test to validate that this migration behaved as expected, but it felt exotic to test a migration so I deleted it.