Skip to content

fix: do not emit DecodingError when response is null #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btrautmann merged 1 commit into from
Dec 23, 2025
Merged

fix: do not emit DecodingError when response is null #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions lib/src/sturdy_http.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,17 @@ class SturdyHttp {
onResponse: onResponse,
);
} on Exception catch (e) {
await _onEvent(
DecodingError(
request: responsePayload.dioResponse!.requestOptions,

@btrautmann btrautmann Dec 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This null check previously caused a NPE (seen when migrating the TT dart client to this version).

exception: e,
stackTrace: StackTrace.current,
),
);
final response = responsePayload.dioResponse;
if (response != null) {
await _onEvent(
DecodingError(
request: response.requestOptions,
exception: e,
stackTrace: StackTrace.current,
),
);
}

rethrow;
}
}
Expand Down
30 changes: 30 additions & 0 deletions test/src/sturdy_http_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,36 @@ void main() {
await expectLater(request, throwsA(isA<TypeError>()));
},
);

test(
'it does not emit a decodingError event when response is null',
() async {
charlatan.whenGet(
'/throws',
(request) =>
throw const SocketException('Connection failed'),
);

final request = buildSubject()
.execute<Json, Result<Foo, String>>(
const GetRequest('/throws'),
onResponse: (response) {
return switch (response) {
OkResponse<Json>(:final response) => Success(
Foo.fromMap(response),
),
GenericError() => throw Exception(
'Decoding error in GenericError',
),
_ => const Failure('Not expected: orElse'),
};
},
);

await expectLater(request, throwsA(isA<Exception>()));
expect(jsonDecodingErrors, isEmpty);
},
);
});
});

Expand Down