feat: add non-namespaced class cop#91
Merged
effron merged 2 commits intoBetterment:mainfrom Jan 27, 2026
Merged
Conversation
frewsxcv
previously approved these changes
Jan 26, 2026
shanshaji
previously approved these changes
Jan 26, 2026
shanshaji
left a comment
shanshaji
left a comment
There was a problem hiding this comment.
Happy to see this change!
I had a similar thought here: https://github.com/Betterment/the-book/pull/302 but lost track of it.
effron
requested changes
Jan 27, 2026
|
|
||
| Betterment/NonNamespacedClass: | ||
| Description: Detects classes that are not namespaced under a module or constant | ||
| StyleGuide: '#bettermentnonamespacedclass' |
Contributor
There was a problem hiding this comment.
can we add a styleguide entry for this?
betterment-policy-bot-production
bot
dismissed stale reviews from frewsxcv and shanshaji
Invalidated by push of c766e99
effron
approved these changes
Jan 27, 2026
Contributor
effron
left a comment
effron
left a comment
There was a problem hiding this comment.
domainLGTM && platformLGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will introduce a new cop that will take offense on the definition of classes that are not namespaced.