docs(demo/readme): add a readme file for demo app#70
Open
fffjacquier wants to merge 1 commit intomasterfrom
Open
docs(demo/readme): add a readme file for demo app#70fffjacquier wants to merge 1 commit intomasterfrom
fffjacquier wants to merge 1 commit intomasterfrom
Conversation
fffjacquier
added
📖 documentation
hpierre74
reviewed
Mar 10, 2022
hpierre74
reviewed
Mar 10, 2022
Comment on lines
+14
to
+15
| - a register.config.ts in src/app | ||
| - a login.config.ts in src/app |
Collaborator
There was a problem hiding this comment.
we shouldn't provide paths and file names, it may change
hpierre74
reviewed
Mar 10, 2022
|
|
||
| #### Link Styled Components | ||
|
|
||
| This page doesn't use any UI library. |
Collaborator
There was a problem hiding this comment.
one could argue styled-components IS a UI library
Collaborator
|
I think we should not be that specific about what's in there, probably a better approach would be to add some contextual info in the demo app code itself - some description on every pages would do the trick and we would change it when developing |
mickaelalvs
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The demo app could be documented in order for people using it to understand why and how to use it
Description
Created a easy to grasp README file
Types of changes
Checklist
Closes #66