Skip to content

Class and Type Synthesis #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
datvo06 wants to merge 72 commits into
base: staging-llm
Choose a base branch
from
Open

Class and Type Synthesis #444

datvo06 wants to merge 72 commits into from

Conversation

@datvo06
Copy link

@datvo06 datvo06 commented Dec 16, 2025 •
edited
Loading

Closes #410, depends on #422

datvo06 added 30 commits December 8, 2025 17:29
@datvo06
Adding lexical context collection
8cfe854
@datvo06
Allow model input to refer to anything within the lexical context
4122acc
@datvo06
Different handling between representable object and other types when …
28fc2c9 
…referred to in Template
@datvo06
More edge case handling
126cab4
@datvo06
More edge case handling
bec5e06
@datvo06
More edge case handling
a768749
@datvo06
Adding mypy check and test
aabb0b7
@datvo06
SynthesizedFunction for constrained decoding, adapt the tests
55cd283
@datvo06
Linting
a232926
@datvo06
Let LLM generate param names
61a9432
@datvo06
Pydantic field annotation
6135eee
@datvo06
Merging notebook
cb3cb07
@datvo06
Linting
40413c5
@datvo06
Fix minor formatting for type context
4d7867b
@datvo06
Update llm dependencies to include mypy
ce8ebcf
@datvo06
More comprehensive error message
246b980
@datvo06
linting
90d933c
@datvo06
More comprehensive import
ac2c953
@datvo06
Merging lexical context
403a46d
@datvo06
Merging lexical context
bce39c9
@datvo06
Merging lexical context
64ecc63
@datvo06
Lint
04d5622
@datvo06
More refractoring to use the lexical context instead of collected typ…
e3741aa 
…e sources
@datvo06
Bring constrained decoding back to synthesized function
362e773
@datvo06
Remove redundant format signature and rely on mypy to check for type …
81a993b 
…consistency
@datvo06
Revert change
a2ada49
@datvo06
Using lexical context
3d4aac7
@datvo06
removing lexical context docstring
80d0353
@datvo06
Using Encodable as interface and resolve merge conflicts
79f07a4
@datvo06
Linting
d2abb9e
@datvo06 datvo06 changed the title [DRAFT PR] Discussion of Class and Type Synthesis Class and Type Synthesis Dec 17, 2025
eb8680
eb8680 reviewed Dec 17, 2025
View reviewed changes
effectful/handlers/llm/type_synthesis.py
_decode_counter: typing.ClassVar[int] = 0

@classmethod
def decode(cls, vl: SynthesizedType, context: LexicalContext | None = None) -> type:
Copy link
Contributor

@eb8680 eb8680 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some really scary stuff happening in here. Is the sole aim to support calling inspect.getsource on the result of decode?

Copy link
Author

@datvo06 datvo06 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@eb8680
Copy link
Contributor

eb8680 commented Dec 23, 2025

@datvo06 as you've started doing in #456, can we pull out any new Encodables added here into standalone PRs? As discussed in #422 these are not specific to synthesis and separating them into smaller PRs will lead to much shorter review cycles.

@datvo06
Copy link
Author

datvo06 commented Dec 23, 2025

@datvo06 as you've started doing in #456, can we pull out any new Encodables added here into standalone PRs? As discussed in #422 these are not specific to synthesis and separating them into smaller PRs will lead to much shorter review cycles.

Hi, thanks! I will do it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eb8680 eb8680 eb8680 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

module:llm status:awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@datvo06 @eb8680