Skip to content

fix: preserve StreamDeckOptions metadata for trimmed .NET 8 apps#88

Open
SergioChan wants to merge 1 commit intoBarRaider:masterfrom
SergioChan:fix-83-trim-streamdeck-options
Open

fix: preserve StreamDeckOptions metadata for trimmed .NET 8 apps#88
SergioChan wants to merge 1 commit intoBarRaider:masterfrom
SergioChan:fix-83-trim-streamdeck-options

Conversation

@SergioChan
Copy link

Summary

  • add a DynamicDependency annotation on SDWrapper.Run(...) for StreamDeckOptions
  • preserve public constructors and properties used by CommandLineParser reflection in trimmed/self-contained .NET 8 publishes
  • scope the annotation to NET8_0_OR_GREATER to avoid impacting netstandard targets

Testing

  • dotnet SDK is not available in this runtime (dotnet: command not found), so build/test could not be executed locally
  • ran git diff --check to confirm no whitespace/patch formatting issues
  • verification intent: a trimmed self-contained plugin publish should no longer throw Type ... StreamDeckOptions appears to be immutable, but no constructor found

Related

Fixes #83

@BarRaider
Copy link
Owner

I think this is resolved in the latest beta released today (7.0-beta.3), can you verify if it resolves your issue?

@SergioChan
Copy link
Author

Thanks for the heads-up on 7.0-beta.3 — I have not validated against that beta yet in this environment. If this is confirmed fixed upstream in beta, I’m happy to close this PR to avoid redundant churn. If you’d like, I can also retarget the change to any remaining gap you still want covered.

@BarRaider
Copy link
Owner

Keep it open for now, when you get a chance to validate let me know.

@SergioChan
Copy link
Author

Thanks — acknowledged. I’m setting up a trim-published .NET 8 sample to validate end-to-end behavior and will report back with exact repro + result matrix (trimmed vs non-trimmed) shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CommandLineParser throws when using streamdeck-tools in .NET 8

2 participants