fix: preserve StreamDeckOptions metadata for trimmed .NET 8 apps#88
Open
SergioChan wants to merge 1 commit intoBarRaider:masterfrom
Open
fix: preserve StreamDeckOptions metadata for trimmed .NET 8 apps#88SergioChan wants to merge 1 commit intoBarRaider:masterfrom
SergioChan wants to merge 1 commit intoBarRaider:masterfrom
Conversation
Owner
|
I think this is resolved in the latest beta released today (7.0-beta.3), can you verify if it resolves your issue? |
Author
|
Thanks for the heads-up on |
Owner
|
Keep it open for now, when you get a chance to validate let me know. |
Author
|
Thanks — acknowledged. I’m setting up a trim-published .NET 8 sample to validate end-to-end behavior and will report back with exact repro + result matrix (trimmed vs non-trimmed) shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynamicDependencyannotation onSDWrapper.Run(...)forStreamDeckOptionsCommandLineParserreflection in trimmed/self-contained .NET 8 publishesNET8_0_OR_GREATERto avoid impacting netstandard targetsTesting
dotnetSDK is not available in this runtime (dotnet: command not found), so build/test could not be executed locallygit diff --checkto confirm no whitespace/patch formatting issuesType ... StreamDeckOptions appears to be immutable, but no constructor foundRelated
Fixes #83