fix: update examples in README and BigIntCoercion class for accurate values#1
Merged
jkyberneees merged 1 commit intomainfrom Oct 4, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes documentation inconsistencies by updating examples in both the README.md and BigIntCoercion class to reflect accurate computed values for various string-to-BigInt conversions and character operations.
Key changes:
- Updated numeric examples to show correct computed values
- Corrected Unicode character representations in comments
- Fixed string-to-BigInt conversion examples with accurate results
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/bigint-coercion.ts | Updated JSDoc examples to show correct Unicode character and numeric values |
| README.md | Fixed string-to-BigInt conversion examples with accurate computed values and character representations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| * new BigIntCoercion(65n).toChar(); // 'A' | ||
| * new BigIntCoercion(8364n).toChar(); // '€' (Euro sign) | ||
| * new BigIntCoercion(128512n).toChar(); // '😀' (would wrap to 16 bits) | ||
| * new BigIntCoercion(128512n).toChar(); // '' (wraps to 16 bits: 62976) |
There was a problem hiding this comment.
The comment shows an empty string ('') but should show the actual Unicode character for code point 62976. Consider using String.fromCharCode(62976) to show the correct character or explain why it appears empty.
Suggested change
| * new BigIntCoercion(128512n).toChar(); // '' (wraps to 16 bits: 62976) | |
| * new BigIntCoercion(128512n).toChar(); // '' (wraps to 16 bits: 62976) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.