F2F-1528 rtcv scraper protocol routes proxyen via app#1
Merged
mjarkk merged 12 commits intoApr 15, 2026
Conversation
Delete app_routes.ts and use `this.isAppMode ? appPath : rtcvPath` at each call site. Simpler, explicit, and easier to clean up when RT-CV is fully integrated (just remove the ternary branches). Also makes isAppMode public readonly so slack.ts can access it.
Collapse F2F_APP_URL + F2F_APP_KEY_ID + F2F_APP_KEY_SECRET into F2F_APP=https://keyId:keySecret@host — same format as RTCV_SERVER, parsed with new URL(). Same for F2F_ALTERNATIVE_APP.
Check res.ok before parsing JSON on both challenge and exchange requests. Without this, a failed challenge silently produces a wrong proof, leading to confusing "invalid proof" errors.
added 2 commits
April 14, 2026 11:48
Use this.alternativeServer.isAppMode instead of this.isAppMode for consistency with how other methods delegate to the alternative server. Not a bug — both always share the same mode — but removes an implicit coupling.
mjarkk
requested changes
Apr 14, 2026
No need to conditionally add it — RT-CV ignores unknown headers, the app requires it.
Distinguishes app credentials from RTCV_SERVER basic auth. f2f://keyId:keySecret@host maps to http://host for requests. No protocol enforcement — just documented convention.
f2f:// maps to http (local dev), f2fs:// maps to https (production). Mirrors the ws:// vs wss:// convention.
Reject other protocols with a clear error message pointing to the correct format.
script-jerem
approved these changes
Apr 14, 2026
mjarkk
approved these changes
Apr 15, 2026
mjarkk
deleted the
F2F-1528-rtcv-scraper-protocol-routes-proxyen-via-app
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F2F_APP modus voor scraper-protocol
Voegt een nieuwe modus toe waarmee scrapers via de f2f-app communiceren met RT-CV in plaats van rechtstreeks.
Wijzigingen
Zonder F2F_APP werkt alles identiek als voorheen.