updating the way tikautils fetches file#2292
Open
truhacevkir wants to merge 4 commits into
Open
Conversation
Test Results 272 files ±0 272 suites ±0 21m 55s ⏱️ - 1m 17s Results for commit 0f78ba8. ± Comparison against base commit d67679c. This pull request removes 183 and adds 24 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
truhacevkir
commented
Jul 2, 2025
| private ScopusFile fetchFileContent(ScopusFile file) throws IOException { | ||
| var response = fetchResponseAsInputStream(file.downloadFileUrl()); | ||
| var inputStream = tikaUtils.fetch(response.request().uri()); | ||
| var inputStream = TikaInputStream.get(response.body()); |
Collaborator
Author
There was a problem hiding this comment.
Consuming inputstream from response directly instead of fetching uri with TikaInputStream.
ketilaa
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.