fix(s3): commit identical S3 versions and isolate git config#82
Merged
Conversation
- Use --allow-empty so byte-identical consecutive S3 versions still produce a commit, keeping a 1:1 version-to-commit mapping - Isolate generated git history from user's global/system git config (GIT_CONFIG_GLOBAL/SYSTEM=/dev/null) - Improve git error messages with exit code, command and working dir
LarsV123
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in
s3 get-versionswhere byte-identical consecutive S3 object versions were silently dropped from the generated git history, and hardens the git invocation.git commit --allow-emptyso byte-identical consecutive S3 versions still produce a commit, keeping a 1:1 version-to-commit mappingGIT_CONFIG_GLOBAL/GIT_CONFIG_SYSTEM=/dev/null) so templates, hooks, signing andincludeIfdon't leak in(no output))https://sikt.atlassian.net/browse/NP-51317