Rfem6 toolkit #140 pushing nodes with constraints triggers issue#141
Open
Arne-Martensen wants to merge 2 commits intodevelopfrom
Open
Rfem6 toolkit #140 pushing nodes with constraints triggers issue#141Arne-Martensen wants to merge 2 commits intodevelopfrom
Arne-Martensen wants to merge 2 commits intodevelopfrom
Conversation
…raints - Add null handling for Node.Support in Equals() to allow pushing unconstrained nodes - Make NodeDistanceComparer a static readonly field to avoid per-call allocation - Simplify null checks using || instead of redundant symmetric conditions - Remove duplicate nodecomp.Equals() call at end of method
Arne-Martensen
added
size:S
Contributor
Author
|
@Arne-Martensen to confirm, the following actions are now queued:
|
Contributor
Author
|
@BHoMBot check versioning |
|
@Arne-Martensen to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
Contributor
Author
|
@BHoMBot check versioning |
|
@Arne-Martensen to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
Contributor
|
@BHoMBot check versioning |
|
@michaelhoehn to confirm, the following actions are now queued:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #140
Fix
NullReferenceExceptioninRFEMNodalComparer.Equals()when pushing nodes without constraints to RFEM.Test files
Changelog
RFEMNodalComparerto handle nodes withnullsupports without throwingNodeDistanceComparerastatic readonlyfield, simplified null checks, removed redundantEquals()callAdditional comments
The root cause was that
RFEMNodalComparer.Equals()did not account forNode.Supportbeingnull. While the null checks existed, a case-sensitivity typo on the field name (_nodecompvs_nodeComp) prevented compilation, and the duplicatenodecomp.Equals()call at the end of the method was unnecessary. Took the opportunity to clean up the overall implementation.