CCE Minor Core Functionality (Edit/View/Withdraw/Modify)

[bledsoef]

Issue Description

Fixes #1399

• Once a proposal is submitted, we cannot currently modify its status (edit, view, withdraw or mark as completed). We need to add functionality to the action dropdown that will allow us to do so.

Changes

• Implemented necessary permissions to allow students to view their minor profile and create proposals.
• Updated all input fields in Request Other Engagement and Summer Experience forms to now populate with existing data, if possible.
• Added new routes to minor/routes.py that load the page with proper permissions.
• Updated the statuses for proposals to match that of Course Proposals.
• Once a proposal is approved by an admin, it can no longer be edited by the student who put it in, only by an admin.
• Added functionality to quickly approve or unapprove a proposal at any stage.

Testing

• Reset database.
• Go to the Minor Management page in the Admin dropdown.
• Select any student's name and go to the Manage Proposals tab.
• Create a new Other Engagement and Summer Experience.
• Mess around with editing data, saving, and making sure it is populated when you go to edit or view it again.
• Run the tests and ensure they work.

[ojmakinde]

mid pr i'll be honest (i haven't looked at it)

[Copilot]

Copilot reviewed 6 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (6)

• app/templates/minor/cceMinorProposalManagement.html: Language not supported
• app/templates/minor/companyOrganizationInformation.html: Language not supported
• app/templates/minor/profile.html: Language not supported
• app/templates/minor/requestOtherEngagement.html: Language not supported
• app/templates/minor/summerExperience.html: Language not supported
• app/templates/minor/supervisorInformation.html: Language not supported

Comments suppressed due to low confidence (2)

app/controllers/minor/routes.py:88

• [nitpick] The function name 'createSummerExperienceExperience' is redundant and may be unclear. Consider renaming it to something like 'createSummerExperienceRequest' to better reflect its purpose.

def createSummerExperienceExperience(username):

app/logic/minor.py:42

• [nitpick] The error message in the updateSummerExperience function reads 'Error saving summer experience' which may be misleading in an update operation. Consider revising the message to indicate an update failure.

def updateSummerExperience(proposalID, formData):

[JohnCox2211]

1

• The flash message below shows on both the view and edit pages. Is that intentional?

2

• The 'Yes' under 'Requested Other Engagement' shows as a clickable link; however, it only links back to the main CCE Minor Management page, so these links take the user nowhere. Should this link exist? Where would it take you if there are multiple requested engagements?

3

• Even if a summer experience has yet to be approved on a student's profile, it still marks the student as having completed a summer experience on the CCE Minor Management main page. If the completed proposal is withdrawn, however, the summer experience returns to being incomplete as it should.

Showing submitted:

4

• The Sustained Engagements count is inconsistent. Ebenezer started with 2/4 Sustained Engagements. I added 3 proposals to Ebenezer's proposal tab: 2 summer and 1 other. I approved 1 summer proposal and 1 other, then returned to the main management page. The Sustained Engagements count was still 2/4. I went back to Ebenezer's page and added 1 more other engagement proposal; however, the Sustained Engagements count was now 4/4 upon returning to the main management page even with the last event added still only having the submitted status.

Before:
Main Page:

Student page:

After:
Main page:

Student page:

The count seems to be inaccurate. Also, I believe the count should reflect the number of completed proposals, not the total count of proposals, including the ones only with the submitted status.

[JohnCox2211]

Once you click 'Save and Approve', 'Submit', or 'Save a Draft' on the edit page of an 'other' proposal, the user is required to submit a file even if one is already attached.

[ojmakinde]

@JohnCox2211, in response to this comment:

Is this intentional?

1. Yes, it is intentional. It's important to communicate that message on any page, and I'm open to any potential improvements.

Should this link exist? Where would it take you if there are multiple requested engagements?

2. Great question. I didn't work on the CCE Minor Landing Page functionality nor did I attempt to integrate it into this PR, which I should have. However, I'm not sure what that button should do. Perhaps we can get rid of the hyperlink. @BrianRamsay, what do you suggest? I believe integrating both of these functionalities should be tackled in a separate PR.

Even if a summer experience has yet to be approved on a student's profile, it still marks the student as having completed a summer experience on the CCE Minor Management main page

The Sustained Engagements count is inconsistent.

3 & 4. The logic controlling the minor page in minor.py will be fixed in a future implementation, as the Minor Profile Page and CCE Minor Engagement page were not integrated into each other in this PR. Work needs to be done on how we measure complete/finished engagements, as this PR adds a status field to proposals that distorts the previous Complete/Incomplete system, I suspect.

5. Fixed the file upload error and improved general form validation.

[bakobagassas]

When I click on submit with backup, nothing seems to happen, not even a flash message

[bakobagassas]

I don't this the view mode should have buttons like save or submit since we are just displaying and not editing anything. I think it should only have the "close" button.

[bakobagassas]

When editing an already existing proposal, for example we just change a name and try to save, there is a validity tag that appears where we are required to attach a file though there is already a file there. Then it saves the changes. That validity tag should not be appearing though. Also this is for when we try to save draft, however, on the other hand when I try to actually submit the proposal, it does not work, it still requires me to add a file while there is already a file attached

[RueHaile]

I don't this the view mode should have buttons like save or submit since we are just displaying and not editing anything. I think it should only have the "close" button.

done!

[github-actions]

View Code Coverage