Conversation
BrianRamsay
left a comment
BrianRamsay
left a comment
There was a problem hiding this comment.
Re-evaluate all of the boolean expressions you have added this to. So far all of them are wrong.
|
The Student Admin doesn't have access to the edit page
|
|
When an admin creates a bonner event, a student admin has access to it when you switch roles |
AndersonStettner
left a comment
AndersonStettner
left a comment
There was a problem hiding this comment.
Need to create tests for new logic.
| <div class="col-md-6 mb-3"> | ||
| <div> | ||
| {{createInputsButtons("searchCeltsAdminInput", "Add Celts Admin")}}<br> | ||
| {% if g.current_user.isCeltsAdmin and not g.current_user.isCeltsStudentAdmin %} |
There was a problem hiding this comment.
Everyone with isCeltsAdmin true will have isCeltsStudentAdmin false, right? So Anderson was right after all, that the second part is redundant.
|
|
…lts into studentAdmin
…lts into studentAdmin
| def getAllowedTemplates(currentUser): | ||
| """Returns a list of all visible templates depending on who the current user is. If they are not an admin it should always be none.""" | ||
| if currentUser.isCeltsAdmin: | ||
| if currentUser.isCeltsAdmin or currentUser.isCeltsStudentAdmin: |
There was a problem hiding this comment.
Should this allow them to see Bonner events?
bledsoef
added
the
on hold
|
Placing on hold because we need to reevaluate what permissions student admins should be able to have. |
|
#1181 creating spreadsheet here |
|
Spreadsheet has been created, still waiting to hear back from @BrianRamsay on whether not the permissions are correct so we can finalize this PR. |
9 participants
Did: fixes #984 and added a new role called student Admin. Student admin should have the same privileges as program managers for all programs aside from Bonner.
Test: