feat(sdk): add wallet adapter layer for browser wallet signing#197
Open
V1ctor-o wants to merge 1 commit into
Open
feat(sdk): add wallet adapter layer for browser wallet signing#197V1ctor-o wants to merge 1 commit into
V1ctor-o wants to merge 1 commit into
Conversation
|
@V1ctor-o Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a wallet adapter abstraction layer to the SDK, enabling unified support for browser-based wallet signing flows across Freighter, Albedo, and future WalletConnect integrations.
The goal is to decouple wallet-specific implementations from the core SDK and provide a consistent interface for transaction signing and wallet management.
What Changed
🧩 Wallet Abstraction
WalletAdapterinterface to define a standard contract for wallet implementations.🔌 Wallet Adapter Implementations
FreighterAdapter
AlbedoAdapter
WalletConnectAdapter (Stub)
🔁 SDK Refactor
bcForgeClientto accept an optionalwalletAdapter.🧠 Wallet State & Helpers
Added wallet connection helper methods to standardize:
connectdisconnectgetPublicKeysignTransactionIntroduced basic connection state handling through adapter interface.
🧪 Tests
📚 Documentation
bcForgeClientwith adaptersBackward Compatibility
Notes
WalletConnectAdapteris intentionally left as a stub because WalletConnect signing flows are application-specific and require project-level configuration.Future Improvements
WalletConnectionError,SigningError, etc.)Closes #172