feat(sdk): add transaction retry with fee bumping and nonce management#190
Open
jerrymusaga wants to merge 1 commit into
Open
feat(sdk): add transaction retry with fee bumping and nonce management#190jerrymusaga wants to merge 1 commit into
jerrymusaga wants to merge 1 commit into
Conversation
|
@jerrymusaga Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #171
Summary
RetryPolicyconfig —maxAttempts,feeBumpMultiplier,maxFeeStroops, exponential backoff params; merged intobcForgeClientConfigtx_insufficient_fee, bumps the inclusion fee by the configured multiplier (default ×1.5) up to a hard cap (default 1 XLM)tx_bad_seq, re-fetches the account (fresh sequence number) before rebuilding the transactiontx_too_latehandling — rebuilds with a fresh timeout/ledger bounds and retries with back-offECONNRESET, 503, 429, etc.)estimateBaseFee()uses the RPCgetFeeStatsp99 inclusion fee as the starting fee for each write transactionIdempotencyTrackerrecords submitted tx hashes within a retry session so timed-out transactions can be re-checked before a fresh submissionTxTooLateError,InsufficientFeeError,BadSequenceError,MaxRetriesExceededError,FeeLimitExceededError(all exported)Test plan
classifyTxErrormaps all three error codes + unknown/undefined casesbumpFeemultiplies, rounds up, caps, and throws at the limitcalculateBackoffDelayexponential growth capped atmaxDelayMsisTransientErrorclassifies RPCError and network error message patternsIdempotencyTrackerrecords and queries submitted hashesexecuteWithRetrysuccess on first attempt, fee-bump retry, back-off retries, exhausted attempts, fee cap, non-retryable errors, idempotency recording, custom initial feenpm test)tsc --noEmit) — no errors