[code sync] Merge code from sonic-net/sonic-swss:202511 to 202601#245
Merged
Conversation
mssonicbld
commented
Jun 24, 2026
mssonicbld
commented
Collaborator
#### Why I did it Implements the fix for sonic-net/sonic-mgmt#24066 When autoneg is configured as 'off' on a platform whose ASIC does not support autoneg, the previous code logged an error and dropped the entire port config task (speed, admin_state etc). #### How I did it Disabling autoneg on such a platform is a no-op — so there is no reason to error out. Skipping allows us to apply the other configs. Changes introduced another else case to handle this scenario gracefully #### How to verify it Before the changes: Links do not come up since the admin_state config is dropped ``` 2026 Apr 21 04:55:49.058252 humm119 ERR swss#orchagent: :- doPortTask: Ethernet0: autoneg is not supported (cap=0) 2026 Apr 21 04:55:49.613104 humm119 ERR swss#orchagent: :- doPortTask: Ethernet244: autoneg is not supported (cap=0) ``` After the changes: Links come up ``` 2026 Apr 21 05:07:05.364331 humm119 INFO swss#orchagent: :- operator(): FIELD: autoneg, VALUE: off 2026 Apr 21 05:07:05.364666 humm119 INFO swss#orchagent: :- doPortTask: Ethernet0: autoneg not supported; disable is no-op 2026 Apr 21 05:07:05.364693 humm119 NOTICE swss#orchagent: :- doPortTask: Set port Ethernet0 autoneg to off 2026 Apr 21 05:07:05.963385 humm119 INFO swss#orchagent: :- operator(): FIELD: autoneg, VALUE: off 2026 Apr 21 05:07:05.963823 humm119 INFO swss#orchagent: :- doPortTask: Ethernet244: autoneg not supported; disable is no-op 2026 Apr 21 05:07:05.963852 humm119 NOTICE swss#orchagent: :- doPortTask: Set port Ethernet244 autoneg to off ``` ``` Ethernet0 96,97,98,99 400G 9100 rs etp1 routed up up QSFP-DD Double Density 8X Pluggable Transceiver N/A Ethernet244 236,237,238,239 400G 9100 rs etp62 routed up up QSFP+ or later with CMIS N/A ``` **Details if related** #### Which release branch to port - [ ] master - [x] 202511 - [ ] 202505 Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.