take interfaces instead of concrete objects helm shim testable#369
Open
paulgmiller wants to merge 2 commits intoAzure:mainfrom
Open
take interfaces instead of concrete objects helm shim testable#369paulgmiller wants to merge 2 commits intoAzure:mainfrom
paulgmiller wants to merge 2 commits intoAzure:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now ojbects have to be serilized by test code then unserialized by input reader.
Then if we want objects out of wrtier we need to deserialize again.
This will let us use simple mocks that just pass the right unstructured objects around.
Also taking interaces is generally good. Could make these interface private took.