Add unit tests and documentation for DDM connection string authentication fix#2354
Draft
Add unit tests and documentation for DDM connection string authentication fix#2354
Conversation
Copilot
AI
changed the title
[WIP] Fix DDM login issue when logging in via connection string
Add unit tests and documentation for DDM connection string authentication fix
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing fix for DDM tab visibility during connection string authentication lacks test coverage and inline documentation explaining the authentication scenario.
Changes
Add unit tests for
isDataMaskingEnabled()covering:Add inline documentation explaining why policy existence check supports connection string authentication where
databaseAccountcapabilities are unavailableContext
When users authenticate via connection string,
isCapabilityEnabled()returnsfalsebecausedatabaseAccountis unavailable. The function correctly falls back to checkinghasDataMaskingPolicyFromCollection, allowing the DDM tab to appear if a policy exists:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.