close input and output stream of request#85
Open
dpproduction wants to merge 1 commit intoAzure:masterfrom
Open
close input and output stream of request#85dpproduction wants to merge 1 commit intoAzure:masterfrom
dpproduction wants to merge 1 commit intoAzure:masterfrom
Conversation
dpproduction
force-pushed
the
fix_resource_leaking
branch
from
11569d3 to
db6a1c7
Compare
|
|
dpproduction
force-pushed
the
fix_resource_leaking
branch
from
db6a1c7 to
e1cd8be
Compare
dpproduction
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strict mode shows that closeable resource was not closed.
I have added a call to the close method for input and output stream of http request.
2021-01-25 17:42:32.911 1958-1967/com.sportics.horbikeapplication E/StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks. java.lang.Throwable: Explicit termination method 'close' not called at dalvik.system.CloseGuard.open(CloseGuard.java:180) at java.net.AbstractPlainSocketImpl.create(AbstractPlainSocketImpl.java:103) at java.net.Socket.createImpl(Socket.java:464) at java.net.Socket.getImpl(Socket.java:530) at java.net.Socket.setSoSndTimeout(Socket.java:1194) at com.android.okhttp.Connection.setTimeouts(Connection.java:508) at com.android.okhttp.Connection.connectAndSetOwner(Connection.java:400) at com.android.okhttp.OkHttpClient$1.connectAndSetOwner(OkHttpClient.java:130) at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:356) at com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:273) at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:478) at com.android.okhttp.internal.huc.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:126) at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getOutputStream(HttpURLConnectionImpl.java:261) at com.android.okhttp.internal.huc.DelegatingHttpsURLConnection.getOutputStream(DelegatingHttpsURLConnection.java:218) at com.android.okhttp.internal.huc.HttpsURLConnectionImpl.getOutputStream(HttpsURLConnectionImpl.java) at com.microsoft.azure.storage.core.ExecutionEngine.executeWithRetry(ExecutionEngine.java:90) at com.microsoft.azure.storage.blob.CloudBlockBlob.uploadFullBlob(CloudBlockBlob.java:726) at com.microsoft.azure.storage.blob.CloudBlockBlob.upload(CloudBlockBlob.java:679) at com.microsoft.azure.storage.blob.CloudBlob.uploadFromByteArray(CloudBlob.java:1665) at com.microsoft.azure.storage.blob.CloudBlockBlob.uploadText(CloudBlockBlob.java:1014) at com.microsoft.azure.storage.blob.CloudBlockBlob.uploadText(CloudBlockBlob.java:984) at com.sportics.horbikeapplication.repositories.azure.AzureBikeInfoUploader.uploadData(AzureBikeInfoUploader.kt:25) at com.sportics.horbikeapplication.repositories.azure.AzureStorageUploadWorker$doWork$2.invokeSuspend(AzureStorageUploadWorker.kt:31) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56) at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:738) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665) 2021-01-25 17:42:32.913 1958-1967/com.sportics.horbikeapplication E/StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks. java.lang.Throwable: Explicit termination method 'close' not called at dalvik.system.CloseGuard.open(CloseGuard.java:180) at java.net.AbstractPlainSocketImpl.create(AbstractPlainSocketImpl.java:103) at java.net.Socket.createImpl(Socket.java:464) at java.net.Socket.getImpl(Socket.java:530) at java.net.Socket.setSoSndTimeout(Socket.java:1194) at com.android.okhttp.Connection.setTimeouts(Connection.java:508) at com.android.okhttp.Connection.connectAndSetOwner(Connection.java:400) at com.android.okhttp.OkHttpClient$1.connectAndSetOwner(OkHttpClient.java:130) at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:356) at com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:273) at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:478) at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:426) at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponseCode(HttpURLConnectionImpl.java:542) at com.android.okhttp.internal.huc.DelegatingHttpsURLConnection.getResponseCode(DelegatingHttpsURLConnection.java:105) at com.android.okhttp.internal.huc.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java) at com.microsoft.azure.storage.core.ExecutionEngine.executeWithRetry(ExecutionEngine.java:106) at com.microsoft.azure.storage.blob.CloudBlob.exists(CloudBlob.java:1831) at com.microsoft.azure.storage.blob.CloudBlob.exists(CloudBlob.java:1818) at com.microsoft.azure.storage.blob.CloudBlob.exists(CloudBlob.java:1793) at com.sportics.horbikeapplication.repositories.azure.AzureLogsUploader.calcLengthDiff(AzureLogsUploader.kt:47) at com.sportics.horbikeapplication.repositories.azure.AzureLogsUploader.uploadData(AzureLogsUploader.kt:29) at com.sportics.horbikeapplication.repositories.azure.AzureStorageUploadWorker$doWork$2.invokeSuspend(AzureStorageUploadWorker.kt:31) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56) at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:738) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665) _