Fixes pandas date method + fix ingest tests race conditions#615
Merged
Fixes pandas date method + fix ingest tests race conditions#615
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes datetime column handling in older pandas versions by correcting the regex pattern used to detect dots in datetime strings and updating related test infrastructure.
Key changes:
- Fixed regex pattern in
parse_datetimeto properly escape the dot character for pandas versions before 2.0 - Changed logical operator from
notto~for pandas boolean Series negation - Refactored E2E tests to create isolated tables per test instead of sharing a single table
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| azure-kusto-data/azure/kusto/data/helpers.py | Fixed regex pattern from "." to "\\." and updated logical operator from not to ~ for proper pandas boolean handling; added force_version parameter for testing; updated type hints to use modern syntax |
| azure-kusto-data/tests/test_helpers.py | Added new test test_datetime_parsing to verify datetime parsing with both pandas v1 and v2 behaviors using the force_version parameter |
| azure-kusto-ingest/tests/test_e2e_ingest.py | Refactored test infrastructure to create unique tables per test with init_table() and drop_table() methods, removing shared table state and improving test isolation |
| CHANGELOG.md | Documented the datetime handling fix for old pandas versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
yogilad
previously approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Changed
Fixed