Skip to content

adding example policies for tpm and circuit breaker#119

Open
maansi-1608 wants to merge 3 commits into
Azure:masterfrom
maansi-1608:maansi/example-policies
Open

adding example policies for tpm and circuit breaker#119
maansi-1608 wants to merge 3 commits into
Azure:masterfrom
maansi-1608:maansi/example-policies

Conversation

@maansi-1608

Copy link
Copy Markdown

Adding policies for

  1. Rate limiting by TPM
  2. Circuit breaker pattern

Comment thread examples/circuitbreaker.xml Outdated
@@ -0,0 +1,41 @@
<policies>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this, circuit breaker is built-in nowadays - https://learn.microsoft.com/en-us/azure/api-management/backends?tabs=bicep#circuit-breaker-preview

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the file, and updated the readme as well.

<base />
<!--Priority Management Based on Subscription Keys:
Applies quotas based on the subscription key. -->
<choose>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason why we don't use set-variable to define the allowed calls and then only define rate-limit-by-key once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants