-
Notifications
You must be signed in to change notification settings - Fork 245
[feat] Fallback mcr.azk8s.cn to mcr.azure.cn in Windows containerd #7646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Title Lint Failed ❌Current Title: Your PR title doesn't follow the expected format. Please update your PR title to follow one of these patterns: Conventional Commits Format:
Guidelines:
Examples:
Please update your PR title and the lint check will run again automatically. |
27d1029 to
e09841e
Compare
| func Test_Windows2022_McrChinaCloud_Windows(t *testing.T) { | ||
| RunScenario(t, &Scenario{ | ||
| Tags: Tags{ | ||
| MockAzureChinaCloud: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we try to change the e2e daemonset test image from mcr.microsoft.com to mcr.azk8s.cn if detect MockAzureChinaCloud=true
| server = "https://$Registry" | ||
| [host."https://$RegistryHost"] | ||
| capabilities = ["pull", "resolve"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to add one header for azk8s.cn?
example
#7515
|
incorrect title |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fallback mcr.azk8s.cn to mcr.azure.cn in Windows containerd
Requirements:
Special notes for your reviewer:
Release note: