Skip to content

Conversation

@jiashun0011
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fallback mcr.azk8s.cn to mcr.azure.cn in Windows containerd

Requirements:

  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version
  • commits are GPG signed and Github marks them as verified

Special notes for your reviewer:

Release note:

[feat] Fallback mcr.azk8s.cn to mcr.azure.cn in Windows containerd

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

PR Title Lint Failed ❌

Current Title: [feat] Fallback mcr.azk8s.cn to mcr.azure.cn in Windows containerd

Your PR title doesn't follow the expected format. Please update your PR title to follow one of these patterns:

Conventional Commits Format:

  • feat: add new feature - for new features
  • fix: resolve bug in component - for bug fixes
  • docs: update README - for documentation changes
  • refactor: improve code structure - for refactoring
  • test: add unit tests - for test additions
  • chore: remove dead code - for maintenance tasks
  • chore(deps): update dependencies - for updating dependencies
  • ci: update build pipeline - for CI/CD changes

Guidelines:

  • Use lowercase for the type and description
  • Keep the description concise but descriptive
  • Use imperative mood (e.g., "add" not "adds" or "added")
  • Don't end with a period

Examples:

  • feat(windows): add secure TLS bootstrapping for Windows nodes
  • fix: resolve kubelet certificate rotation issue
  • docs: update installation guide
  • Added new feature
  • Fix bug.
  • Update docs

Please update your PR title and the lint check will run again automatically.

func Test_Windows2022_McrChinaCloud_Windows(t *testing.T) {
RunScenario(t, &Scenario{
Tags: Tags{
MockAzureChinaCloud: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we try to change the e2e daemonset test image from mcr.microsoft.com to mcr.azk8s.cn if detect MockAzureChinaCloud=true

server = "https://$Registry"
[host."https://$RegistryHost"]
capabilities = ["pull", "resolve"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to add one header for azk8s.cn?
example
#7515

@fseldow
Copy link
Contributor

fseldow commented Jan 13, 2026

incorrect title
starts with feat: instead of [feat]
The purpose of pr is not fallback mcr.azk8s.cn. It is to redirect the host

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants