feat(access-control): advanced settings for RSS content restriction by dkoo · Pull Request #4613 · Automattic/newspack-plugin

dkoo · 2026-03-30T22:32:25Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Adds an Advanced Settings modal in the Access Control wizard page to contain options that don't fit into any other UI views or components. Implements the following options:

Restrict content in feeds - Truncate restricted content in RSS feeds. Enabled by default.
Hide Everlit in restricted content - Prevents Everlit audio embed blocks from rendering in restricted content. Enabled by default. Note: we've removed this option as this should be handled by the Everlit plugin, not here.

Closes NPPD-1035.

How to test the changes in this Pull Request:

In Audience > Access Control, confirm that the "Advanced settings" item in the dropdown menu next to the page title is no longer disabled:

Click it and confirm it shows the new modal:

Toggle off the option, save, refresh, and confirm that the saved settings persist.
Test the "undo" link in the snackbar after saving and confirm that it undoes the most recent save.
Leave the option toggled off and save.
Publish a content gate that applies to all posts with Registered and Paid Access enabled + metering.
Visit your RSS feed (https://sitedomain/feed) and confirm that all restricted articles show their full content.
Toggle on the option and save.
Repeat steps 7-8 and confirm that the feed shows truncated content for restricted posts unless logged into a user account that has full access

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

Copilot

Pull request overview

Adds “Advanced settings” support to the Audience → Access Control wizard, introducing backend-stored toggles to (1) truncate restricted posts in RSS feeds and (2) optionally hide Everlit embeds in restricted content.

Changes:

Adds an Advanced Settings modal to the Access Control wizard UI and wires it to a new wizard settings REST endpoint.
Introduces a new Content_Gate_Settings backend class to enforce feed truncation and Everlit block stripping based on saved options.
Adds unit tests covering feed truncation behavior and Everlit stripping behavior.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`tests/unit-tests/content-gate/test-advanced-settings.php`	Adds unit tests for feed truncation and Everlit stripping behavior.
`src/wizards/audience/views/content-gates/types/index.d.ts`	Adds TS types for `advanced_settings` returned in wizard config.
`src/wizards/audience/views/content-gates/content-gates.tsx`	Enables “Advanced settings” menu item and mounts the new modal component.
`src/wizards/audience/views/content-gates/advanced-settings.tsx`	Implements the Advanced Settings modal UI and saving/undo via REST.
`includes/wizards/audience/class-audience-content-gates.php`	Adds REST endpoint to update advanced settings and exposes settings in wizard config.
`includes/content-gate/class-content-gate.php`	Ensures the new settings class is loaded during Content Gate initialization.
`includes/content-gate/class-content-gate-settings.php`	New settings class: option storage + feed truncation + Everlit block stripping hooks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/wizards/audience/views/content-gates/advanced-settings.tsx

includes/content-gate/class-content-gate-settings.php

includes/wizards/audience/class-audience-content-gates.php

thomasguillot · 2026-04-01T10:15:50Z

@dkoo — Thomas has reviewed these changes and will be marking this PR as design approved.

Changes pushed in the latest commit:

Moved modal action buttons inside the VStack for correct layout flow
Switched Institutions menu item from href: '#/institutions' to history.push('/institutions') via the router proxy, for consistent SPA navigation
Fixed AdvancedSettingsConfig type — restrict_content_feeds was a typo; renamed to restrict_feeds to match the PHP and component code

miguelpeixe

Tested well! Left a couple of non-blocking suggestions and a small issue.

miguelpeixe · 2026-04-02T16:13:33Z

includes/content-gate/class-content-gate-settings.php

+/**
+ * Main class.
+ */
+class Content_Gate_Settings {


Not to be confused with the component at src/wizards/audience/views/content-gates/content-gate-settings.tsx

Non-blocking suggestion: we could make this class just about the RSS feed handling. It is already by implementing the feed restriction on top of the settings, just need to make it official with the docblocks and class name 😄

I can see a year from now, this class having 1000+ lines of small features and patches mixed together...

I see your point, but this class is kind of where I envision we'll add additional "global" settings beyond just this RSS option, hence why it originally also owned the Everlit option. What if we renamed it to Content_Gate_Advanced_Settings or Content_Gate_Global_Settings?

I think Content_Gate_Advanced_Settings is better.

00d01c4 renames the class to Content_Gate_Global_Settings (and the test class too) to hopefully make the intention a bit clearer.

miguelpeixe · 2026-04-02T16:23:06Z

tests/unit-tests/content-gate/test-advanced-settings.php

+/**
+ * Tests for RSS feed content restriction.
+ */
+class Test_Advanced_Settings extends \WP_UnitTestCase {


Also non-blocking, but I think we can have this either for RSS Feed restriction control alone or just additional tests within tests/unit-tests/content-gate/content-gates.php. "Advanced settings" is just a UI layer.

00d01c4 renames this to Test_Global_Settings to match the renamed class it tests.

miguelpeixe · 2026-04-02T16:42:13Z

src/wizards/audience/views/content-gates/advanced-settings.tsx

+	const wizardData = useWizardData( AUDIENCE_CONTENT_GATES_WIZARD_SLUG ) as WizardData;
+	const { wizardApiFetch, isFetching, resetError, setError } = useWizardApiFetch( AUDIENCE_CONTENT_GATES_WIZARD_SLUG );
+	const { addNotice, resetNotices, updateWizardSettings } = useDispatch( WIZARD_STORE_NAMESPACE );
+	const [ config, setConfig ] = useState< AdvancedSettingsConfig >( ( wizardData?.config?.advanced_settings as AdvancedSettingsConfig ) || {} );


The AdvancedSettings component is always mounted, so changing config, closing, and re-opening the modal will show stale data. I don't think we need to introduce a dirty state confirmation modal, but might be a good idea to reset on close here.

The component always being mounted is intentional, as this is what allows the Undo button in the Snackbar component that appears after saving to function (otherwise the prior state in the ref is lost when the component unmounts). The internal config state is updated after a successful save in tandem with the wizard store, using the same data, so it's not likely to get out of sync. If you're worried about this being possibly too fragile we could do away with the "Undo" button so the component can be unmounted when the modal isn't visible. But so far I haven't run into any trouble with the component state and store data getting out of sync. 🤷

I see... I had a different UX perception for this. When I open something in a modal, make changes, and close without clicking the Save button, I'd not expect that state to be preserved. I'd also not expect that closed modal state to be persisted if I click save somewhere else.

That's a valid point. b748566 fixes that issue, so that the local state is reset upon closing the modal. Also applies the same fix to the Premium Newsletters advanced settings modal, which uses the same component pattern (maybe we could combine these into one reusable component in the future).

If I save the new value, opening the modal again will render the state from page load.

…s, for clarity

dkoo · 2026-04-02T17:22:19Z

@miguelpeixe thanks for the feedback! Happy to discuss further if you feel the changes aren't enough

dkoo added 4 commits March 30, 2026 16:32

feat(access-control): advanced settings

dbb99f7

refactor: use render_block for better performance

3e4e762

chore: re-word Everlit option for clarity

9c025e1

fix: also remove everlit embeds from front-end metered posts

49d9b10

dkoo self-assigned this Mar 31, 2026

dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 31, 2026

dkoo marked this pull request as ready for review March 31, 2026 21:45

dkoo requested a review from a team as a code owner March 31, 2026 21:45

Copilot AI review requested due to automatic review settings March 31, 2026 21:45

Copilot started reviewing on behalf of dkoo March 31, 2026 21:46 View session

dkoo requested a review from thomasguillot March 31, 2026 21:48

dkoo added the [Status] Needs Design Review label Mar 31, 2026

Copilot AI reviewed Mar 31, 2026

View reviewed changes

dkoo and others added 2 commits March 31, 2026 15:59

fix: copilot feedback

bf55bb7

fix: modal button layout, institutions nav, AdvancedSettingsConfig type

f553525

thomasguillot added [Status] Design Approved and removed [Status] Needs Design Review labels Apr 1, 2026

thomasguillot removed their request for review April 1, 2026 10:17

chore: remove everlit handling (handled by Everlit plugin)

37376b9

dkoo changed the title ~~feat(access-control): advanced settings~~ feat(access-control): advanced settings for RSS content restriction Apr 2, 2026

chore: remove ALL the everlit

fe0b02b

miguelpeixe requested changes Apr 2, 2026

View reviewed changes

github-actions bot added the [Status] Needs Changes or Feedback The issue or pull request needs action from the original creator label Apr 2, 2026

refactor: rename Content_Gate_Settings to Content_Gate_Global_Setting…

00d01c4

…s, for clarity

dkoo requested a review from miguelpeixe April 2, 2026 17:21

dkoo added 2 commits April 2, 2026 13:15

fix: discard local state if closing modal without saving

b748566

fix: missing files

44e7a46

Conversation

dkoo commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thomasguillot commented Apr 1, 2026

Uh oh!

miguelpeixe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkoo commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dkoo commented Mar 30, 2026 •

edited

Loading