Skip to content

Conversation

@elijah-potter
Copy link
Collaborator

Issues

Supercedes #2488

Description

This PR changes the library we use to decompress the thesaurus at runtime to a Rust-only library, ruzstd. This avoids the compiler problems illustrated by #2488 on MacOS systems.

@hippietrail, would you mind checking if this PR actually fixes your problem?

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes

@hippietrail
Copy link
Collaborator

hippietrail commented Jan 15, 2026

with just test-chrome-plugin I get 11 failures

  11 failed
    [chromium] › tests/testUtils.ts:96:2 › Can apply basic suggestion. ─────────────────────────────
    [chromium] › tests/hn.spec.ts:49:1 › Hacker News scrolls correctly ─────────────────────────────
    [chromium] › tests/lexical_webcomponent.spec.ts:16:2 › Lexical webcomponent regression › Applying a suggestion does not duplicate text 
    [chromium] › tests/lexical.spec.ts:12:1 › Can apply basic suggestion. ──────────────────────────
    [chromium] › tests/lexical.spec.ts:32:1 › Can ignore suggestion. ───────────────────────────────
    [chromium] › tests/nested_elements.spec.ts:6:1 › Positions properly in oddly nested page. ──────
    [chromium] › tests/prosemirror.spec.ts:12:1 › Can apply basic suggestion. ──────────────────────
    [chromium] › tests/testUtils.ts:149:2 › Can hide with rule block button ────────────────────────
    [chromium] › tests/simple_textarea.spec.ts:19:1 › Wraps correctly ──────────────────────────────
    [chromium] › tests/simple_textarea.spec.ts:45:1 › Scrolls correctly ────────────────────────────
    [chromium] › tests/slate.spec.ts:33:1 › Can ignore suggestion. ─────────────────────────────────
  18 passed (2.8m)
 ELIFECYCLE  Test failed. See above for more details.
error: Recipe `test-chrome-plugin` failed with exit code 1

just test different probably due to timing, how busy the system was, etc...?

  7 failed
    [chromium] › tests/hn.spec.ts:26:1 › Hacker News wraps correctly ───────────────────────────────
    [chromium] › tests/hn.spec.ts:49:1 › Hacker News scrolls correctly ─────────────────────────────
    [chromium] › tests/lexical_webcomponent.spec.ts:16:2 › Lexical webcomponent regression › Applying a suggestion does not duplicate text 
    [chromium] › tests/lexical.spec.ts:12:1 › Can apply basic suggestion. ──────────────────────────
    [chromium] › tests/nested_elements.spec.ts:6:1 › Positions properly in oddly nested page. ──────
    [chromium] › tests/prosemirror.spec.ts:12:1 › Can apply basic suggestion. ──────────────────────
    [chromium] › tests/simple_textarea.spec.ts:19:1 › Wraps correctly ──────────────────────────────
  22 passed (2.3m)
 ELIFECYCLE  Test failed. See above for more details.
error: Recipe `test-chrome-plugin` failed with exit code 1

@elijah-potter
Copy link
Collaborator Author

Those tests might just be failing on your system. CI is the canonical runner. Are the WASM build issues gone on this branch?

@hippietrail
Copy link
Collaborator

hippietrail commented Jan 16, 2026

Those tests might just be failing on your system. CI is the canonical runner. Are the WASM build issues gone on this branch?

I think that was all the error output so I guess so? I'm trying to get the detect_browser_dialect branch working with this now. I'm pretty confused about it at the moment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants