feat: detect browser dialect #2485
Open
+72
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-potter
requested changes
Jan 15, 2026
Collaborator
elijah-potter
left a comment
elijah-potter
left a comment
There was a problem hiding this comment.
This PR is close. There are some irrelevant changes that seem to have crept in without explanation. Overall, I'm a big fan.
| } | ||
|
|
||
| /** Detect English dialect from browser language settings */ | ||
| function detectBrowserDialect(): Dialect { |
Collaborator
There was a problem hiding this comment.
This logic seems sound. I'd prefer it in its own file with some tests attached.
| }); | ||
|
|
||
| let linter: LocalLinter; | ||
| let linterReady = false; |
Collaborator
There was a problem hiding this comment.
This is redundant. If the linter is null, we can assume it is not ready. This variable doesn't provide additional information and can become inconsistent with the type system if used incorrectly.
| } | ||
|
|
||
| function initializeLinter(dialect: Dialect) { | ||
| async function initializeLinter(dialect: Dialect) { |
Collaborator
There was a problem hiding this comment.
This function does not need to be modified for this PR.
Collaborator
Author
There was a problem hiding this comment.
This function does not need to be modified for this PR.
I think the bits you're questioning are from the second commit where we (agent and I) were trying to track down the build problems. So they might be "clutching at straws" before we figured out that the problems were in the WASM/thesaurus stuff and not in the new feature we were working on.
Thanks for casting a more expert eye over it!
|
|
||
| // If user hasn't set a dialect, try to detect from browser language | ||
| if (resp.dialect === undefined) { | ||
| return detectBrowserDialect(); |
Collaborator
Author
|
Sorry @elijah-potter I don't know what changed but when I try to pick up where I left off in this branch I get errors that are outside my wheelhouse and the LLM doesn't give me confidence... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
The Harper browser extension always starts in US English mode on Chrome and Safari. I made sure I had my OS and browser settings all on Australian English and no difference.
This is a 99% agent-coded fix to detect the browser language region (dialect) setting.
I've looked at the code but so far I haven't been able to run the tests. Hence just a draft PR for now.
Demo
How Has This Been Tested?
Manually only so far.
Checklist