feat(cli): chunk annotations #2450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `annotate_tokens` -> `annotate`.
Implement `RandomColorIter` to make color generation code more reusable.
Also display a more descriptive for `Annotate` reports.
Collaborator
|
This looks really nice - and useful! |
elijah-potter
previously approved these changes
Jan 12, 2026
Collaborator
elijah-potter
left a comment
elijah-potter
left a comment
There was a problem hiding this comment.
As @hippietrail said, this looks great! Good work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The primary focus of this PR is to add the option to annotate chunks in
harper-cli annotate. With the-i/--isolate-englishoption, this should make it easier to visualize/debug theIsolateEnglishparser.annotate_tokenstoannotate.annotateto support more general annotations, rather than being limited to just tokens.Chunksas an annotation option toharper-cli annotate.SingleInputTrait::load_with_parser()to allow overriding an input's choice of parser. (This is used here to tack onIsolateEnglishto the input's parser selection.)-i/--isolate-englishoption toharper-cli annotate.Demo
How Has This Been Tested?
harper-cli annotate.Checklist