Don't call do_blocks on non-block comments #191
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The core https://core.trac.wordpress.org/browser/trunk/src/wp-includes/blocks.php#L1504 Why is it needed here and not in core? |
|
Hi @johngodley, thank you for reviewing, good point, I think we need it there too. We did not know about this same logic in core. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing plain text is wasteful, and more importantly breaks core WordPress tests when Blocks Everywhere is enabled.
Because the core tests have a comment with the body "Hello World", which is parsed into a block without a name. And this breaks this assertion, since the comment will contain 6 blocks (not 5) and one of them will be a nameless block with
innerHTML=Hello World.