Conversation
|
Hi @aroller , May I ask you for a review on this one please? Thank you in advance. |
|
Hi @ajanani85, Is there a chance to get this change reviewed and if all is good, merged and tagged off with a new version? Unfortunately @aroller didn't respond for some time now. Thank you in advance for your help. |
|
That you for the review @aroller , it is much appreciated. Not sure if there are any further steps needed from me in order to get this merged. If so, please let me know. Thank you again. |
|
I'm not involved in the repository any longer, but your change looked straightforward and required. I didn't see any testing so make sure it works. Otherwise merge if you can. I'm mobile and couldn't figure out how to merge for you in the app |
|
@aroller thank you for the response. Unfortunately I don't have write access to the repo so cannot merge it. There should be a green merge button at the bottom of the comment thread if one has. Not sure who to ping to get it merged 😞 As for the tests, my fork is in use for a couple of months now on some private projects, so it definitely works. |
Fixes #18