fix: shared-client Close() safety in adapters; harden CI workflows#13
Merged
Conversation
- mcp, mark3labs: `(*Adapter).Close()` is now a no-op for adapters built with `NewAdapterFromClientAndResource`. Such adapters do not own the caller-supplied `*authplane.Client`, so closing one adapter no longer tears down a client shared across other adapters. `NewAdapter`-built adapters still own and close the client they create. - http: `(*Adapter).RequireScopes` now names every missing scope in the `error_description` instead of returning on the first miss, by delegating to `claims.RequireScopes`. Middleware-enforced and code-enforced scope checks now surface the same diagnostic (RFC 6750 §3). - ci: add CodeQL analysis and workflow linting (actionlint + shellcheck), pin third-party actions to commit SHAs, and clear Scorecard findings. - mcp: bump indirect `golang.org/x/sys` to v0.44.0.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
RobertoIskandarani
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code-only batch since the last release: two adapter fixes plus CI/security hardening.
(*Adapter).Close()is now a no-op for adapters built withNewAdapterFromClientAndResource— closing one no longer tears down a caller-supplied client shared across adapters.NewAdapter-built adapters still own and close it.(*Adapter).RequireScopesnames every missing scope inerror_description(was: stopped at the first miss) by delegating toclaims.RequireScopes(RFC 6750 §3).golang.org/x/systo v0.44.0 (mcp).Testing
go vet/go build/go test -race ./...green across core, http, mark3labs, mcp (conformance included);golangci-lint run— 0 issues per module.