Open
Conversation
bresch
requested changes
Feb 18, 2026
| y = np.asarray(y).flatten() | ||
|
|
||
| n_steps = len(u) | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
no need for this new line
autotune/system_identification.py
Outdated
Comment on lines
+119
to
+120
| theta_hat = rls._theta_hat | ||
| theta_hat = np.array(theta_hat).flatten() |
Collaborator
There was a problem hiding this comment.
Suggested change
| theta_hat = rls._theta_hat | |
| theta_hat = np.array(theta_hat).flatten() | |
| theta_hat = np.array(rls._theta_hat).flatten() |
Collaborator
|
Could you try this instead? |
ppjosip
force-pushed
the
pr-numpy-update-error
branch
from
36742d6 to
514c987
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script crashed on Python 3.13.7 with NumPy 2.4.2. The crash was caused by stricter rules introduced for scalar promotion and array indexing.
NumPy 2.0 removed the legacy behavior that allowed "Rank-1" arrays (e.g., the result of indexing into a column vector) to be implicitly cast as scalars during assignment to a single matrix index.