Skip to content

refactor: make s3_uri_to_key a public helper in results_utils#28

Merged
vtnphan merged 2 commits intoreports-linksfrom
copilot/sub-pr-27
Mar 16, 2026
Merged

refactor: make s3_uri_to_key a public helper in results_utils#28
vtnphan merged 2 commits intoreports-linksfrom
copilot/sub-pr-27

Conversation

Copy link
Contributor

Copilot AI commented Mar 16, 2026

_s3_uri_to_key was a private-by-convention function in results_utils.py that was being imported directly into job_utils.py, violating module encapsulation and making future refactors fragile.

Changes

  • results_utils.py: Renamed _s3_uri_to_keys3_uri_to_key; updated internal call site in _get_run_output_keys
  • job_utils.py: Updated import and call site to use the renamed public function
# Before
from .results_utils import _s3_uri_to_key, get_sample_id_for_result, sync_bindcraft_outputs

# After
from .results_utils import get_sample_id_for_result, s3_uri_to_key, sync_bindcraft_outputs

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: vtnphan <53896516+vtnphan@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on reports and download links implementation refactor: make s3_uri_to_key a public helper in results_utils Mar 16, 2026
Copilot AI requested a review from vtnphan March 16, 2026 22:38
@vtnphan vtnphan marked this pull request as ready for review March 16, 2026 22:39
@vtnphan vtnphan merged commit 4b26830 into reports-links Mar 16, 2026
@vtnphan vtnphan deleted the copilot/sub-pr-27 branch March 16, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants