refactor: make s3_uri_to_key a public helper in results_utils#28
Merged
vtnphan merged 2 commits intoreports-linksfrom Mar 16, 2026
Merged
refactor: make s3_uri_to_key a public helper in results_utils#28vtnphan merged 2 commits intoreports-linksfrom
s3_uri_to_key a public helper in results_utils#28vtnphan merged 2 commits intoreports-linksfrom
Conversation
8 tasks
Co-authored-by: vtnphan <53896516+vtnphan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on reports and download links implementation
refactor: make Mar 16, 2026
s3_uri_to_key a public helper in results_utils
vtnphan
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_s3_uri_to_keywas a private-by-convention function inresults_utils.pythat was being imported directly intojob_utils.py, violating module encapsulation and making future refactors fragile.Changes
results_utils.py: Renamed_s3_uri_to_key→s3_uri_to_key; updated internal call site in_get_run_output_keysjob_utils.py: Updated import and call site to use the renamed public function🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.