Skip to content

Move static files to a public folder and implement basic CI/CD pipeline #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rccarlson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move static files to a public folder and implement basic CI/CD pipeline #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
name: Build and Deploy to GitHub Pages

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]

jobs:
test:
name: Run Tests
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4

# TODO: Add test commands here
# Examples:
# - name: Install dependencies
# run: npm install
# - name: Run unit tests
# run: npm test
# - name: Run integration tests
# run: npm run test:integration

deploy:
name: Deploy to GitHub Pages
runs-on: ubuntu-latest
needs: test
Comment on lines +10 to +29
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test job has no actual test steps, causing it to succeed immediately without performing any validation. While the TODO comment acknowledges this is planned for later, consider either adding a placeholder test command that fails with a clear message indicating tests need to be implemented, or remove the test job entirely until tests are ready. An always-passing test job can create a false sense of security in the CI/CD pipeline.

Suggested change
test:
name: Run Tests
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
# TODO: Add test commands here
# Examples:
# - name: Install dependencies
# run: npm install
# - name: Run unit tests
# run: npm test
# - name: Run integration tests
# run: npm run test:integration
deploy:
name: Deploy to GitHub Pages
runs-on: ubuntu-latest
needs: test
deploy:
name: Deploy to GitHub Pages
runs-on: ubuntu-latest

Copilot uses AI. Check for mistakes.
if: github.ref == 'refs/heads/main' && github.event_name == 'push'
permissions:
contents: read
pages: write
id-token: write
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Setup Pages
uses: actions/configure-pages@v4

- name: Upload artifact
uses: actions/upload-pages-artifact@v3
with:
path: './public'

- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v4
0 index.html → public/index.html
View file
Open in desktop
File renamed without changes.
0 style.css → public/style.css
View file
Open in desktop
File renamed without changes.