Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements very basic gamepad support for Linux by using libudev and evdev. Just like the X11 and OpenGL implementation, the code dynamically loads libudev, given that they have the library on the system, which all systemd-based distributions should have, as far as I understand. If they don't then the application will run without gamepad support and without notifying the user of missing libudev.
The controllers that support BTN_GAMEPAD should work out of the box, given that they follow the Linux Gamepad specificiation. So far, a PS3 controller and a PS5 controller worked.
What is not handled:
SYN_DROPPEDwill be sent to us whenever there is a "buffer overrun in the evdev client’s event queue". Not 100% sure how you handle this.What is not tested:
I would recommend that the above gets tested before a merge.
The controller example was also changed to run through all four controllers instead of only the first one.