Skip to content

[Snyk] Security upgrade shakapacker from 6.5.5 to 9.5.0 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karimkawambwa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade shakapacker from 6.5.5 to 9.5.0 #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ gem 'oj'
gem 'pg'
gem 'puma'
gem 'rails'
gem 'shakapacker'
gem 'shakapacker', '>= 9.5.0'
Copy link
Copy Markdown

@sentry sentry Bot Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The shakapacker gem is updated to v9.5.0+ while the corresponding npm package remains at v6.5.5, creating an incompatible version mismatch that will break the application.
Severity: CRITICAL

Suggested Fix

Update the shakapacker package in package.json to a version compatible with the gem (e.g., ~9.5.0). Run bundle install and yarn install to update Gemfile.lock and yarn.lock. Also, update the code to use the new APIs from shakapacker v9+, such as changing require "webpacker" to require "shakapacker" and using generateWebpackConfig().

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: Gemfile#L25

Potential issue: The `Gemfile` updates the `shakapacker` gem to version `9.5.0+`, but
`package.json` and `yarn.lock` are not updated, leaving the JavaScript package at
`6.5.5`. This version mismatch will cause critical failures. The new gem version (v9+)
has removed APIs that are still used in the codebase, such as `require "webpacker"` in
`bin/webpacker` and the `webpackConfig` export in `webpack.config.js`. Consequently,
asset compilation will fail with a `LoadError` or `TypeError`, and the development
server will not start, making the application non-functional.

Did we get this right? 👍 / 👎 to inform future reviews.

gem 'sqlite3'
gem 'tiny_tds'
gem 'tzinfo-data'
Expand Down