Skip to content

Correct quit statement for Temp maternal transfer#62

Merged
cecilieha merged 8 commits into
devfrom
temp_maternal_transfer
May 6, 2026
Merged

Correct quit statement for Temp maternal transfer#62
cecilieha merged 8 commits into
devfrom
temp_maternal_transfer

Conversation

@hmorzaria

@hmorzaria hmorzaria commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Your commits explain the who, what, where and when of these changes. Your code shows the how. You do not need to reiterate this. This PR should complete the big picture by telling the why.

Justification

Describe the big picture of your changes here to communicate to the reviewers why they should accept this pull request.
Please describe the importance/impact of the problem and a description of how the changes in this pull request will address, resolve or improve the problem.

Beth added a quit statement in at_demography.c for when maternal transfer was on and had externally reproducing species, but the necessary code has been added and the quit statement is no longer necessary

/*   if(bm->track_contaminants && bm->flag_contamMaternalTransfer){
                        quit("Have not coded contaminant transfer for externally reproducing species - if you get this message contact teh developer group and ask them to sort this for you.... if it involves salmon Beth may swear, don't worry she will be fine after a bowl of ice cream\n");
                 } */

If it fixes a bug or resolves a feature request, be sure to link to the issue below.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other change (if none of the other choices apply)
    Remove quit statement that was placeholder for missing code

Further comments

If this is a New Feature, Breaking change, or a bug fix, the Atlantis Manual will need to be updated to reflect these changes.
Now would be a good time to create an issue in the Atlantis Manual repo and begin documenting your changes.

  • I've created an issue
  • This is NA

Reviewer instructions:

Assign at least 2 reviewers:

  • one of which should be a maintainer,
  • the others should be familiar with the subject changes. Please add these under the assignees field

Please detail the process reviewers will need to follow to properly test these changes. It is especially helpful to identify the exact code needed to conduct a local build/review/test and to specify any aspects of the testing that may not be obvious.

hmorzaria and others added 7 commits April 23, 2026 06:24
Added a licence file in different form so can more easily work with public version of the repository
Updated to match CSIRO open source licence
U[dated for licence link in prep of going public
Corrected typos in the README and added new information on other applications of Atlantis models
@hmorzaria hmorzaria requested a review from cecilieha May 4, 2026 21:59

@cecilieha cecilieha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No differences between this and dev simulation, as expected.

@cecilieha cecilieha merged commit e2c8b47 into dev May 6, 2026
1 check passed
@cecilieha cecilieha deleted the temp_maternal_transfer branch May 6, 2026 14:07
@andybeet andybeet mentioned this pull request May 6, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants