Skip to content

refactor(#54): print version release to console#55

Merged
cecilieha merged 5 commits into
devfrom
fix/i54-print-release
May 6, 2026
Merged

refactor(#54): print version release to console#55
cecilieha merged 5 commits into
devfrom
fix/i54-print-release

Conversation

@andybeet

@andybeet andybeet commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

Your commits explain the who, what, where and when of these changes. Your code shows the how. You do not need to reiterate this. This PR should complete the big picture by telling the why.

Justification

SVN release number was printed in log file. This has been replaced by GitHub version release in an earlier PR. For this to work git is required as a system dependency. This will not work for the SETAS workflow. This version number also needs to be printed to standard out. This PR fixes the standard out printing

fixes #54

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other change (if none of the other choices apply)

Further comments

If this is a New Feature, Breaking change, or a bug fix, the Atlantis Manual will need to be updated to reflect these changes.
Now would be a good time to create an issue in the Atlantis Manual repo and begin documenting your changes.

  • I've created an issue
  • This is NA

Reviewer instructions:

The automated workflow for the SETAS model will not display the model version number. It will be listed as "unknown". It is not straightforward to get this to display from a github action. However, for users compiling the model outside of a container this will work since it will have access to the .git folder (assuming the model was cloned from this repo). For users on systems running atlantis in a docker container, they will need to copy the .git folder rather than the .svn folder into the container prior to building, since that is now where the version number resides.

@andybeet andybeet marked this pull request as ready for review April 23, 2026 15:08
@andybeet andybeet marked this pull request as draft April 24, 2026 09:17
@andybeet

Copy link
Copy Markdown
Collaborator Author

@cecilieha FYI: So the printing of the release to the log file all works for models running Atlantis in a container. No code changes will be needed, just a fix to how the container is built. phew!!

@andybeet andybeet marked this pull request as ready for review April 30, 2026 16:13
@andybeet andybeet requested a review from cecilieha April 30, 2026 16:14

@cecilieha cecilieha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes does not lead to any differences in the output (first 100 timesteps checked), and the print to the log.txt file works as it should.

@cecilieha cecilieha merged commit 75d7794 into dev May 6, 2026
1 of 2 checks passed
@cecilieha cecilieha deleted the fix/i54-print-release branch May 6, 2026 07:07
@andybeet andybeet mentioned this pull request May 6, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants