refactor(#54): print version release to console#55
Merged
Conversation
Collaborator
Author
|
@cecilieha FYI: So the printing of the release to the log file all works for models running Atlantis in a container. No code changes will be needed, just a fix to how the container is built. phew!! |
cecilieha
approved these changes
May 6, 2026
cecilieha
left a comment
Collaborator
There was a problem hiding this comment.
The changes does not lead to any differences in the output (first 100 timesteps checked), and the print to the log.txt file works as it should.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your commits explain the
who,what,whereandwhenof these changes. Your code shows thehow. You do not need to reiterate this. This PR should complete the big picture by telling thewhy.Justification
SVN release number was printed in log file. This has been replaced by GitHub version release in an earlier PR. For this to work git is required as a system dependency. This will not work for the SETAS workflow. This version number also needs to be printed to standard out. This PR fixes the standard out printing
fixes #54
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that applyFurther comments
If this is a New Feature, Breaking change, or a bug fix, the Atlantis Manual will need to be updated to reflect these changes.
Now would be a good time to create an issue in the Atlantis Manual repo and begin documenting your changes.
Reviewer instructions:
The automated workflow for the SETAS model will not display the model version number. It will be listed as "unknown". It is not straightforward to get this to display from a github action. However, for users compiling the model outside of a container this will work since it will have access to the
.gitfolder (assuming the model was cloned from this repo). For users on systems running atlantis in a docker container, they will need to copy the.gitfolder rather than the.svnfolder into the container prior to building, since that is now where the version number resides.