Skip to content

Update CHANGELOG.md#53

Merged
andybeet merged 3 commits into
devfrom
hmorzaria-patch-1
May 26, 2026
Merged

Update CHANGELOG.md#53
andybeet merged 3 commits into
devfrom
hmorzaria-patch-1

Conversation

@hmorzaria

@hmorzaria hmorzaria commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

Added Commit number for new release and revised missing information

Your commits explain the who, what, where and when of these changes. Your code shows the how. You do not need to reiterate this. This PR should complete the big picture by telling the why.

Justification

Need to keep CHANGELOG updated

If it fixes a bug or resolves a feature request, be sure to link to the issue below.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other change (if none of the other choices apply)

Documentation

Further comments

If this is a New Feature, Breaking change, or a bug fix, the Atlantis Manual will need to be updated to reflect these changes.
Now would be a good time to create an issue in the Atlantis Manual repo and begin documenting your changes.

  • I've created an issue
  • This is NA

Reviewer instructions:

Assign at least 2 reviewers:

  • one of which should be a maintainer,
  • the others should be familiar with the subject changes. Please add these under the assignees field

Please detail the process reviewers will need to follow to properly test these changes. It is especially helpful to identify the exact code needed to conduct a local build/review/test and to specify any aspects of the testing that may not be obvious.

Added Commit number for new release and revised missing information
@hmorzaria hmorzaria requested a review from andybeet April 23, 2026 13:45
@hmorzaria hmorzaria requested review from andybeet and jacobkasper and removed request for andybeet and jacobkasper April 30, 2026 22:33
@andybeet

andybeet commented May 8, 2026

Copy link
Copy Markdown
Collaborator

@hmorzaria Since this PR additional content has been pulled into dev. Does any of this have an impact on the changelog notes? Also as noted above, i think the changelog should have the same formatting from release to release. Not sure the current changelog entry does.

@andybeet andybeet changed the base branch from main to dev May 8, 2026 13:51
@jacobkasper

Copy link
Copy Markdown
Collaborator

@hmorzaria Can you please clarify for me what I am reviewing?

@andybeet

Copy link
Copy Markdown
Collaborator

@jacobkasper not sure you have been tagged as a reviewer on this PR.

But ... the content in dev due to be merged into main can be found here #61. Since this changelog is meant to reflect all new changes in main, I was just suggesting that we make sure the changloge reflects this.

In addition, I noticed that some of the entries in the changelog are bulleted, some are not. Thought we might want to bullet all points

@andybeet andybeet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See earlier comments

Comment thread CHANGELOG.md Outdated
@jacobkasper

Copy link
Copy Markdown
Collaborator

@jacobkasper not sure you have been tagged as a reviewer on this PR.

But ... the content in dev due to be merged into main can be found here #61. Since this changelog is meant to reflect all new changes in main, I was just suggesting that we make sure the changloge reflects this.

In addition, I noticed that some of the entries in the changelog are bulleted, some are not. Thought we might want to bullet all points

I see now, I was tagged and then I was removed. I think that is a good idea though to have everything bulleted.

@hmorzaria

Copy link
Copy Markdown
Collaborator Author

@andybeet I think the easiest at this point is for me to close this pull request and modify the change log again with all the changes in Dev. The problem is that the changes in the Changelog need to be approved promptly if we are going to require a reviewer. Maybe designate a rotating documentation reviewer- it could change monthly? I submitted this PR while in Bergen and assigned it to you @jacobkasper and @somros at different times in the hope that someone would approve it soon. The next release is also stuck because of the Changelog

@andybeet

andybeet commented May 19, 2026

Copy link
Copy Markdown
Collaborator

I dont think you need to close this. But if you want to, i dont have objections

The changelog should be merged into main (via dev) with all of the other changes currently in dev. Then there shouldnt be an issue of speed. If the changelog doesnt describe what is in dev, then the code doesnt get pulled into main.

We shouldnt be bypassing dev.

hmorzaria added 2 commits May 22, 2026 18:55
Added missing pullets and revisions from last pull request to dev
@hmorzaria hmorzaria dismissed andybeet’s stale review May 23, 2026 02:40

Requested changes applied in new commit to temp branch

@hmorzaria

Copy link
Copy Markdown
Collaborator Author

@andybeet updated the Changelog in my temp branch, added missing bullets and changes that will be pushed to dev. Changelog should be current. If you review and pull into dev, then after you approve pull request #61 we can do the new release. Is @eafulton reviewing #61 ?

@andybeet andybeet self-requested a review May 26, 2026 14:22
@andybeet andybeet merged commit 19554ee into dev May 26, 2026
1 check passed
@andybeet andybeet deleted the hmorzaria-patch-1 branch May 26, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants