Skip to content

Fix BiTAC_sp memory allocation#5

Merged
cecilieha merged 5 commits into
devfrom
kevcazedits
Apr 30, 2026
Merged

Fix BiTAC_sp memory allocation#5
cecilieha merged 5 commits into
devfrom
kevcazedits

Conversation

@KevCaz

@KevCaz KevCaz commented Mar 11, 2025

Copy link
Copy Markdown
Collaborator

My PR includes 2 commits:

Given that the way to contribute is not established yet, I understand my changes may not be integrated, but I thought it was easy enough to do the PR since I have access to the code!

@KevCaz KevCaz requested a review from eafulton March 11, 2025 15:07
@andybeet

andybeet commented Nov 10, 2025

Copy link
Copy Markdown
Collaborator

@KevCaz Thanks for this. We are a little behind in organizing and establishing protocols. We had a workshop in September that helped us focus on the repos needs. Hopefully we will speed things up. Either way, this should be a PR into dev

@KevCaz KevCaz changed the base branch from main to dev January 27, 2026 21:49
Fixed BiTAC_sp with Util_Alloc_Init_4D_Double instead for consistency sake

@eafulton eafulton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the issue with Util_Alloc_Init_4D_Double instead

@eafulton

Copy link
Copy Markdown
Contributor

Guessing someone needs to cross check/review the change I made before it can have a final merge and close?

@eafulton eafulton self-assigned this Apr 25, 2026
@andybeet andybeet requested a review from cecilieha April 27, 2026 13:05
@andybeet

Copy link
Copy Markdown
Collaborator

yes @eafulton. I added @cecilieha as the second reviewer

@cecilieha cecilieha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run the original code and this one, and compared all variables for the first 100 timesteps (using NoBa); there are no differences between the two, the outputs are identical.

@cecilieha cecilieha merged commit 4f86801 into dev Apr 30, 2026
1 check passed
@cecilieha cecilieha deleted the kevcazedits branch April 30, 2026 11:26
@andybeet andybeet mentioned this pull request Apr 30, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants