Fix BiTAC_sp memory allocation#5
Merged
Merged
Conversation
Collaborator
|
@KevCaz Thanks for this. We are a little behind in organizing and establishing protocols. We had a workshop in September that helped us focus on the repos needs. Hopefully we will speed things up. Either way, this should be a PR into dev |
Fixed BiTAC_sp with Util_Alloc_Init_4D_Double instead for consistency sake
eafulton
reviewed
Apr 25, 2026
eafulton
left a comment
Contributor
There was a problem hiding this comment.
Fixed the issue with Util_Alloc_Init_4D_Double instead
Contributor
|
Guessing someone needs to cross check/review the change I made before it can have a final merge and close? |
Collaborator
|
yes @eafulton. I added @cecilieha as the second reviewer |
cecilieha
approved these changes
Apr 30, 2026
cecilieha
left a comment
Collaborator
There was a problem hiding this comment.
I've run the original code and this one, and compared all variables for the first 100 timesteps (using NoBa); there are no differences between the two, the outputs are identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My PR includes 2 commits:
AtlantisTrunk/atlantis/atmanage/atManage.c
Line 2382 in 9f99af0
Given that the way to contribute is not established yet, I understand my changes may not be integrated, but I thought it was easy enough to do the PR since I have access to the code!