fix(config): wait for background installs on dispose#3
fix(config): wait for background installs on dispose#3
Conversation
|
Updated this PR with two follow-up commits:
What changed in this update:
Re-verified locally after the latest changes:
Also ran a fresh-eyes review loop on the final diff. The last review came back with no P0/P1 findings. |
|
Quick status update on this PR. The scope has narrowed quite a bit. The recent commits have all been in the same area: config-scoped dependency installs, tool discovery timing, and Windows lock cleanup. The latest commit adds a retry in The current blocker in the latest CI run is on Ubuntu. It fails in Windows is still running as I post this. Assuming Windows does not reveal a different failure first, the next fix should stay narrow: adjust the registry/config wait boundary so unrelated global installs do not stall local tool loading. |
Summary
config-install:win32lock leak with a regression test that models disposal plus a follow-up installRoot Cause
On Windows, config dependency installs share the global flock key
config-install:win32. We started those installs in the background during config loading, but instance disposal did not wait for them to settle. A previous instance could therefore keep holding the lock after teardown, and later tests would time out waiting on the leaked lock.Testing