Open
Conversation
Author
|
To test this integration without a doing a release yourself please point your Cartfile to |
kevin-hirsch
requested changes
Sep 15, 2016
Collaborator
kevin-hirsch
left a comment
There was a problem hiding this comment.
Hello @rroy1590,
Thanks a lot for this PR! Everything seems fine 👌
I would just change the names of the schemes/targets to Demo and KVNProgress so the actual lib available through Carthage will be KVNProgress and not KVNProgressKit. I did this for one of my other project: DropDown. Here's a screenshot of the configuration:

|
Hey guys. Do you think it's possible to finalise the Carthage support anytime soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UIColorin a category header