fix: NPCs disappearing when targets enter different map instances #2798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a player aggros an NPC and then enters a different map instance (dungeon, dies, etc.), the NPC would attempt to reset and chase an unreachable target. This caused NPCs to become stuck in a reset loop or disappear from their spawn map entirely. The fix clears the NPC's target and aggro center immediately when the target switches to a different MapInstanceId, preventing the NPC from attempting to path to or reset towards an unreachable location. Fixes #2769 Signed-off-by: Arufonsu <17498701+Arufonsu@users.noreply.github.com>
Arufonsu
added
bug
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a player aggros an NPC and then enters a different map instance (dungeon, dies, etc.), the NPC would attempt to reset and chase an unreachable target. This caused NPCs to become stuck in a reset loop or disappear from their spawn map entirely.
The fix clears the NPC's target and aggro center immediately when the target switches to a different MapInstanceId, preventing the NPC from attempting to path to or reset towards an unreachable location.
(Hopefully) Fixes #2769