docs: fix securitygroup create and securityrule create examples#249
Merged
Conversation
The vpc-id is a positional argument, not a --vpc-id flag. Fix all example files (EN, IT) to use the correct command syntax: acloud network securitygroup create <vpc-id> --name ... --region ... Also fix the securityrule create examples that used non-existent flags (--direction Inbound, --port-range-min/max, --remote-ip-prefix). The correct flags are --direction Ingress/Egress, --port, --target-kind, and --target-value. Additionally, remove the securityrule update examples that incorrectly showed --port and --target-value as updateable (only --name and --tags can be updated). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
=======================================
Coverage 78.20% 78.20%
=======================================
Files 53 53
Lines 12593 12593
=======================================
Hits 9848 9848
Misses 1575 1575
Partials 1170 1170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aru-amedeo
pushed a commit
that referenced
this pull request
Jun 22, 2026
First stable GA release. Covers the two fixes landed since v0.5.3: - #249/#251: securitygroup/securityrule doc examples corrected - #250/#251: create-command completion for nested resources, vpnroute completion gap, and subnet ExactArgs constraint Also adds the v0.5.3 comparison link which was previously missing from the footer, and updates [Unreleased] to point to v1.0.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--vpc-idflag. All example pages were updated to use the correct positional syntax.--direction Inbound,--port-range-min/max,--remote-ip-prefix). Replaced with the actual flags:--direction Ingress/Egress,--port,--target-kind,--target-value, plus the required--nameand--region.--portand--target-valueas updatable. Only--nameand--tagscan be updated; the invalid examples were removed and a note was added.Files changed
docs/website/docs/examples/database.mddocs/website/docs/examples/containerregistry.mddocs/website/docs/it/examples/database.mddocs/website/docs/it/examples/containerregistry.mddocs/website/i18n/it/docusaurus-plugin-content-docs/current/examples/database.mddocs/website/i18n/it/docusaurus-plugin-content-docs/current/examples/containerregistry.mddocs/website/docs/resources/network/securityrule.mdTest plan
acloud network securitygroup create --helpand confirm vpc-id is a positional argumentacloud network securityrule create --helpand confirm the correct flag namesCloses #248
🤖 Generated with Claude Code