cw#10
Open
ArtyomLobanov wants to merge 1 commit into
Open
Conversation
Owner
Author
|
нет yml, поэтому не проходит |
jzuken
reviewed
Apr 8, 2017
| public class Tester { | ||
| public static void main(String[] args) throws Exception { | ||
| // String path = args[0]; | ||
| String path = "C:\\workspace"; |
There was a problem hiding this comment.
закомментированная строка тоже грустная, кстати, хорошо бы проверить, что аргументы вообще передали
| if (!file.exists()) { | ||
| throw new FileNotFoundException(file.getAbsolutePath()); | ||
| } | ||
| FileInputStream input = new FileInputStream(file); |
There was a problem hiding this comment.
при чтении из файла лучше пользоваться try-with-resources
| if (files == null) { | ||
| throw new ForkJoinTaskException(new IOException("Cant retrieve files")); | ||
| } | ||
| ArrayList<ParallelHashCalculator> calculators = new ArrayList<>(); |
There was a problem hiding this comment.
лучше бы List<ParallelHashCalculator> calculators = new ArrayList<>();
| import java.io.File; | ||
| import java.util.Arrays; | ||
|
|
||
| public class Tester { |
There was a problem hiding this comment.
а тут бы тоже не помешали комментарии. по-хорошему их надо писать ко всему, что public
| @@ -0,0 +1,18 @@ | |||
| import java.io.File; | |||
| import org.junit.Test; | ||
|
|
||
| import java.io.File; | ||
| import java.io.FileNotFoundException; |
|
|
||
| public class HashMD5Test { | ||
|
|
||
| private static final String workspace = "test_workspace"; |
There was a problem hiding this comment.
лучше использовать http://junit.org/junit4/javadoc/4.12/org/junit/rules/TemporaryFolder.html
| * @throws FileNotFoundException if some file was not found | ||
| * @throws IOException if its occured during file reading | ||
| */ | ||
| private static byte[] hashFile(@NotNull File file) throws NoSuchAlgorithmException, IOException { |
There was a problem hiding this comment.
NotNull'ов можно было и побольше поставить
|
8.5 баллов |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.