Skip to content

Fix MiniMessage tags broken by redundant replacement loop in I18n.format() #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix MiniMessage tags broken by redundant replacement loop in I18n.format() #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4f43c3
Initial plan
Copilot Feb 26, 2026
edddf17
Fix MiniMessage parse issue: remove broken loop in I18n and update TP…
Copilot Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions Essentials/src/main/java/com/earth2me/essentials/I18n.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,14 +190,7 @@ private String format(final Locale locale, final String string, final Object...
return ess.getAdventureFacet().legacyToMini(ess.getAdventureFacet().escapeTags(arg.toString()));
});

String result = messageFormat.format(processedArgs).replace('\u00A0', ' '); // replace nbsp with a spaceeplace(' ', ' '); // replace nbsp with a space

// Replace temporary placeholders back to actual values for MiniMessage tags
for (int i = 0; i < processedArgs.length; i++) {
result = result.replace("{" + i + "}", processedArgs[i].toString());
}

return result;
return messageFormat.format(processedArgs).replace('\u00A0', ' '); // replace nbsp with a space
}

public static Object[] mutateArgs(final Object[] objects, final Function<Object, String> mutator) {
Expand Down
6 changes: 3 additions & 3 deletions Essentials/src/main/resources/messages_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1430,9 +1430,9 @@ treeCommandUsage1Description=Spawns a tree of the specified type where you''re l
treeFailure=<dark_red>Tree generation failure. Try again on grass or dirt.
treeSpawned=<primary>Tree spawned.
true=<green>true<reset>
typeTpacancel=<primary>To cancel this request, type <secondary>/tpacancel<primary>.
typeTpaccept=<primary>To teleport, type <secondary>/tpaccept<primary>.
typeTpdeny=<primary>To deny this request, type <secondary>/tpdeny<primary>.
typeTpacancel=<primary>To cancel the request to {0}, type <secondary>/tpacancel<primary>.
typeTpaccept=<primary>To accept {0}''s teleport request, type <secondary>/tpaccept<primary>.
typeTpdeny=<primary>To deny {0}''s request, type <secondary>/tpdeny<primary>.
typeWorldName=<primary>You can also type the name of a specific world.
unableToSpawnItem=<dark_red>Cannot spawn <secondary>{0}<dark_red>; this is not a spawnable item.
unableToSpawnMob=<dark_red>Unable to spawn mob.
Expand Down
6 changes: 3 additions & 3 deletions Essentials/src/main/resources/messages_pt_BR.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1428,9 +1428,9 @@ treeCommandUsage1Description=Gera uma árvore do tipo especificado onde você es
treeFailure=<dark_red>Erro ao gerar árvore. Tente novamente na terra ou na grama.
treeSpawned=<primary>Árvore gerada.
true=<green>verdadeiro<reset>
typeTpacancel=<primary>Para cancelar essa solicitação, digite <secondary>/tpacancel<primary>.
typeTpaccept=<primary>Para teleportar, digite <secondary>/tpaccept<primary>.
typeTpdeny=<primary>Para recusar o pedido, digite <secondary>/tpdeny<primary>.
typeTpacancel=<primary>Para cancelar a solicitação de {0}, digite <secondary>/tpacancel<primary>.
typeTpaccept=<primary>Para aceitar o pedido de teleporte de {0}, digite <secondary>/tpaccept<primary>.
typeTpdeny=<primary>Para recusar o pedido de {0}, digite <secondary>/tpdeny<primary>.
typeWorldName=<primary>Você pode também digitar o nome de um mundo específico.
unableToSpawnItem=<dark_red>Não pode criar <secondary>{0}<dark_red>; esse item não e criável.
unableToSpawnMob=<dark_red>Incapaz de spawnar o mob.
Expand Down