Open
Conversation
Contributor
|
github actions file may also need to be updated to reflect the new dockerfile paths urNode/.github/workflows/publish-image.yml Lines 35 to 54 in c3a43fe |
RoguedBear
suggested changes
Nov 1, 2022
| - name: Build and publish a Docker image for ${{ github.repository }} | ||
| uses: macbre/push-to-ghcr@master | ||
| with: | ||
| #dockerfile: Docker/Dockerfile |
Contributor
There was a problem hiding this comment.
this part may actually have to be uncommented, otherwise the action may look for Dockerfile in the repository root location and not the Docker/ folder.
you can check these changes work or result in error by manually triggering the action.
you can do that by visiting the actions tab in your fork and you will see a button "Run workflow" from which you can manually trigger the docker build action (below image is from my fork's action tab)
Author
|
well well, looks like this is still open |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

this solves #11